Starting a new filesystem/filesystem-internal library
#1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This, but unironically: https://xkcd.com/927/ The idea is to: - Pick a small set of filesystem functionality we can support across VScode extensions, Node FS, browserFS, and whatever the next not-quite-a-real-fs platform is. - Compile with a different filesystem-internal in different contexts (CPO will override this builtin import) that always has a consistent interface that is relatively easy to provide across contexts - Allow `filesystem` to rely on that interface to provide any Pyret-level users with the desired functionality
Also add 'buffer' npm repo to support easily polyfilled Buffer calls on the kinds of values you get back from readFile across browser and CLI
|
OK, this would be good to move on merging. There's more testing that would be nice to do. This has the API that is needed for most work in the compiler, though it's not strictly necessary to do everything in the compiler with It has the common-denominator things we need to do sensible filesystem stuff in the extension (with the appropriate RPC calls and The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a WIP, not worth comments yet but I find keeping a PR open and up-to-date useful.
It is this, but unironically: https://xkcd.com/927/
The idea is to:
filesystemto rely on that interface to provide any Pyret-level users with the desired functionality